Fix app crash after initial loading screen #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you would like me to review this PR, either tag me in a comment or check this box:
You can disable automatic comments on my settings page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The app was crashing immediately after the initial loading screen due to a conflict in the implementation of the
addTabBarLEDEffectmethod, which was defined in bothUITabBar+LED.swiftandUIView+LED.swiftextensions.Changes
UITabBar+LED.swiftas the primary implementationUIView+LED.swiftextensionTabbarView.swiftto clarify which implementation is being usedTesting
These changes should resolve the crash that occurs immediately after the app loads. The app should now be able to proceed past the initial loading screen without crashing.
💻 View my work • About Codegen